Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindgenをv0.62.0に上げる #29

Merged
merged 11 commits into from
Feb 8, 2024
Merged

bindgenをv0.62.0に上げる #29

merged 11 commits into from
Feb 8, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 7, 2024 •
edited
Loading

内容

以下のよくわからないエラーを解消するためにbindgenをv0.62.0に上げます。
(最新版はv0.69.4)

https://github.com/VOICEVOX/open_jtalk-rs/actions/runs/7818992027/job/21330728105?pr=18

bindgenのchangelogにあったこれを目当てにとりあえずv0.62.0にしましたが、どうやら上手く直る模様。

  • Various issues with upcoming clang/libclang versions have been fixed.

関連 Issue

スクリーンショット・動画など

その他

コード生成部分の更新はgen_bind workflowに任せようかと思います。

@qryxip
Copy link
Member Author

qryxip commented Feb 7, 2024

gen_bind、if: failure()が機能していないっぽいですね... mainのCIステータスも ❌ で埋まってる。compositeにすると駄目とか?

open_jtalk-rs/.github/actions/auto_gen_bind_pr/action.yml

Lines 56 to 57 in a16714c

- name: do nothing
if: failure()

image

@qryxip qryxip requested a review from Hiroshiba February 7, 2024 18:56
@qryxip qryxip mentioned this pull request Feb 7, 2024
Merged
@Hiroshiba
Copy link
Member

このブランチに向けて発射されてるあまたのプルリクをこのブランチにマージしないといけない…はず…？

github-actions bot and others added 10 commits February 8, 2024 20:10
@github-actions @qryxip
Automated generate bindings for aarch64-unknown-linux-gnu (#19)
dfe329c 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for aarch64-linux-android (#20)
6877a9f 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for x86_64-linux-android (#21)
d8ba2c5 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for x86_64-apple-ios (#22)
6d62a8e 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for x86_64-apple-darwin (#23)
bd8b3d4 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for aarch64-apple-ios (#24)
a178488 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for aarch64-apple-darwin (#25)
f443907 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for aarch64-apple-ios-sim (#26)
9ab0089 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for i686-pc-windows-msvc (#27)
3594158 
Co-authored-by: qryxip <[email protected]>
@github-actions @qryxip
Automated generate bindings for x86_64-pc-windows-msvc (#28)
decd7e6 
Co-authored-by: qryxip <[email protected]>
Hiroshiba
Hiroshiba approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

そういえばbindingの更新ですが、いろんな差分を１つにするのをエディタ側で実装したので同じような仕組みが作れるかもです。

こんな感じでgit diffでpatch作って、
https://github.com/VOICEVOX/voicevox/pull/1761/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R148
こんな感じでgit applyする感じです。
https://github.com/VOICEVOX/voicevox/pull/1761/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R177

以前はartifactを任意個取ってくるのが面倒だったのですが、今はmerge-multiple: trueするとマージできるので結構お手軽だったりします。
https://github.com/VOICEVOX/voicevox/pull/1761/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R171

@Hiroshiba Hiroshiba merged commit 70c76bb into main Feb 8, 2024
37 checks passed
@qryxip qryxip mentioned this pull request Feb 10, 2024
Merged
@Hiroshiba Hiroshiba deleted the bump-bindgen-to-v0.62.0 branch February 11, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba